feat(keycard): Add support for keycard channel events#19548
Merged
alexjba merged 10 commits intofix/keycard-nfc-2from Jan 14, 2026
Merged
feat(keycard): Add support for keycard channel events#19548alexjba merged 10 commits intofix/keycard-nfc-2from
alexjba merged 10 commits intofix/keycard-nfc-2from
Conversation
alexjba
requested review from
Khushboo-dev-cpp,
caybro,
iurimatias,
micieslak and
saledjenic
and removed request for
a team and
iurimatias
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19548#1 🔹 ~14 min 🔹 86711e0 🔹 📦 tests/ui package |
Member
Member
Member
Member
✔️ status-desktop/e2e/prspr19548 🔹 ~17 min 🔹 86711e0 🔹 📦 tests/e2e package |
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
39ed060 to
d281472
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
86711e0 to
e71a2fa
Compare
Member
Member
Member
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19548#2 🔹 ~29 min 🔹 e71a2fa 🔹 📦 tests/ui package |
Member
Member
Member
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
d281472 to
e64335b
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
e71a2fa to
adabada
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
bcf9a24 to
aab486b
Compare
Member
Jenkins BuildsClick to see older builds (112)
|
caybro
reviewed
Dec 22, 2025
| notify = keycardChannelStateChanged | ||
|
|
||
| # Constants for channel states (readonly properties for QML) | ||
| proc getStateIdle*(self: View): string {.slot.} = |
Member
There was a problem hiding this comment.
These read-only constant properties could go to some QML enums, wdyt? Unless you really need them on the NIM side as well
Contributor
Author
There was a problem hiding this comment.
Makes sense. I'll update the following PR where I'm actually using these constants.
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
41159d3 to
d606f25
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
aab486b to
668b750
Compare
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
d606f25 to
ded587b
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
668b750 to
e2f0b36
Compare
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
ded587b to
8c7900d
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
e2f0b36 to
98d9bc1
Compare
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
8c7900d to
809d7d7
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
98d9bc1 to
af922f9
Compare
caybro
approved these changes
Jan 12, 2026
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
809d7d7 to
623dfe7
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
af922f9 to
b8b31ae
Compare
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
623dfe7 to
1a7ec9c
Compare
The keycard channel events will inform the app of the channel state (waiting for keycard, reading, error, idle). This will be used on mobile platforms to control a drawer that informs the user when it's required to tap the keycard.
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
b8b31ae to
44d162b
Compare
…keycard interactions Adding a `KeycardChannelDrawer` that's guiding the user whenever the keycard is needed. On IOS the system drawer is used
…ponents - use a single KeycardStateDisplay instance with the necessary states - The state queue, transitions and entire logic moved to KeycardChannelStateManager component
The constants are moved from nim to qml
- Adding states for HW adaptor states - Implement `Dismiss` action
…ing blocked This commit updates parts of the login flows. Adds a new `Scan keycard` button to trigger keycard detection on demand. + Update keycard states in the login flow + Show digits only on soft keyboard for pin input to squash - fix: User needs to be able to dismiss the keycard drawer without getting blocked
…ger keycard detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do
Iterates #19545
The keycard channel events will inform the app of the channel state (waiting for keycard, reading, error, idle). This will be used on mobile platforms to control a drawer that informs the user when it's required to tap the keycard.
status-keycard-qt adds these new events driven by the channel state.
NOTE: Tests can be done in the final PR #19549